Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10187

XHTML error in ucp_groups_manage.html

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.8
    • Fix Version/s: 3.0.10-RC1
    • Component/s: Styles
    • Labels:
      None

      Description

      phpBB3/styles/prosilver/template/ucp_groups_manage.html: Lines 150 (</tbody>) and 151 (</table>) close tags that are not open, if the BEGINELSE clause on line 145 is executed (no users in the group). A quick fix would be to simply insert "<table><tbody>" after line 145.

      XHTML errors result in major loss of function when the forum is served with MIME type application/xhtml+xml, though most people don't do that.

      I'm not sure that its a good idea to have conditional blocks that open tags without closing them - isn't that simply to ask for XML errors? If </tbody></table> are outside of the BEGIN-block (starting on line 107), shouldn't the <table><tbody> also be outside the BEGIN-block? Alternatively, shouldn't the BEGIN-block close all the tags that it opens? If the logic went like: IF(there are pending members) { <table><thead>...</thead><tbody> BEGIN(pendingmembers)

      { <tr>...</tr> }

      </tbody></table> } IF(there are approved members)

      { ... }

      — if the logic went like that, every tag would have an end-tag in the same conditional block, so that the potential for XML errors is much lower. (I think that solution involves rewriting some of the PHP code, though, so just implement the quick fix mentioned above for now.)

        Attachments

          Activity

            People

            • Assignee:
              bantu Andreas Fischer
              Reporter:
              christian von schultz christian von schultz
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: