Details
Improvement
Trivial
Description
In the file "styles/prosilver/template/index_body.html is at line 38 this:
<!-- IF S_DISPLAY_BIRTHDAY_LIST and BIRTHDAY_LIST -->
|
<h3>{L_BIRTHDAYS}</h3>
|
<p><!-- IF BIRTHDAY_LIST -->{L_CONGRATULATIONS}: <strong>{BIRTHDAY_LIST}</strong><!-- ELSE -->{L_NO_BIRTHDAYS}<!-- ENDIF --></p>
|
<!-- ENDIF -->
|
Why is there "BIRTHDAY_LIST" twice? Has it a reason?
Activity
Well, I'd say thats what the S_DISPLAY_ (controllable over ACP) is for.
On the otherside it might be useful to just display the list when there are birthdays (which is the case now)
No. subsilver2 for example has the "and BIRTHDAY_LIST" removed and thus also shows the birthday bar when there is no birthday. prosilver on the other side does only show the birthday list when there are birthdays today.
On the otherside it might be useful to just display the list when there are birthdays (which is the case now)
You should probably be aware that a significant # of prosilver users ask how to get the birthday list to display even when there are no birthdays so it would appear that subsilver2's behavior is the most desired state. A section stating "there are no birthdays today" is far more informative than the absence of the birthday section altogether. I've found dozens of topics from users thinking their board was broken when they enabled birthday listings and nothing displayed. 
Proposed Patch would be to change the above into:
<!-- IF S_DISPLAY_BIRTHDAY_LIST -->
|
<h3>{L_BIRTHDAYS}</h3>
|
<p><!-- IF BIRTHDAY_LIST -->{L_CONGRATULATIONS}: <strong>{BIRTHDAY_LIST}</strong><!-- ELSE -->{L_NO_BIRTHDAYS}<!-- ENDIF --></p>
|
<!-- ENDIF -->
|
(quite simple)
Needs a Pull Request
Could have been intentional so one could just remove the first "and BIRTHDAY_LIST".