Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10158

Return link not really useful after sending a Private Message

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.8
    • Fix Version/s: 3.0.9-RC1
    • Labels:
      None

      Description

      After you send a PM you are presented with the following:

      This message has been sent successfully.

      View your submitted private message

      Return to your "Outbox" folder

      And are then redirected to the message you just created. The redirect is not so much of a problem. What I have an issue with is the "Return to your "Outbox" folder" link. This is not the folder I was in. I was in my Inbox. I haven't looked at the code but I'm pretty sure there is nothing checking what folder you sent a message from as this is the same message I get when creating a new PM or replying to one. Regardless of that the most common place to go back to, at least in my opinion, would be the Inbox not the Outbox.

        Activity

        Hide
        nickvergessen Joas Schilling added a comment -

        Seems reasonable for me.

        Show
        nickvergessen Joas Schilling added a comment - Seems reasonable for me.
        Hide
        A_Jelly_Doughnut A_Jelly_Doughnut added a comment -

        +1. 3.0.9 would be nice

        Show
        A_Jelly_Doughnut A_Jelly_Doughnut added a comment - +1. 3.0.9 would be nice
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        Patch seems to work as advertised, however I am not sure this is quite right.

        If I reply to a message in a folder (i.e. not in inbox) then a back link should lead to that folder. Currently the user has choice between inbox and outbox neither of which is the folder they were in.

        Show
        Oleg Oleg [X] (Inactive) added a comment - Patch seems to work as advertised, however I am not sure this is quite right. If I reply to a message in a folder (i.e. not in inbox) then a back link should lead to that folder. Currently the user has choice between inbox and outbox neither of which is the folder they were in.
        Hide
        nickvergessen Joas Schilling added a comment -

        We need to get the folder name inside that function.
        There are basically 3 ways we could do that:
        1. It is available in the ucp_pm class, so we could change the signature and pass the folders as a parameter (implemented: https://github.com/nickvergessen/phpbb3/commit/437013194a516932b6f85ba4ee355dcf5836ef19 )
        2. globalize the variable from 1. instead of changing the functions signature.
        3. do an extra query to get it.

        Show
        nickvergessen Joas Schilling added a comment - We need to get the folder name inside that function. There are basically 3 ways we could do that: 1. It is available in the ucp_pm class, so we could change the signature and pass the folders as a parameter (implemented: https://github.com/nickvergessen/phpbb3/commit/437013194a516932b6f85ba4ee355dcf5836ef19 ) 2. globalize the variable from 1. instead of changing the functions signature. 3. do an extra query to get it.
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        When replying to a message that is in a custom folder I get 4 links:

        This message has been sent successfully.

        View your submitted private message

        Return to your “59” folder

        Return to your “Inbox” folder

        Return to your “Outbox” folder

        First, only one of them probably should be labeled "return to" with the remaining links being "go to". Which link to label "return to" is a good question. I can suggest the following: if replying to a message, the folder where that message is gets "return to" link; when composing a message, all folders are "go to" linked.

        Second, the inbox link in this case feels cluttering. What would be a use case for it?

        Show
        Oleg Oleg [X] (Inactive) added a comment - When replying to a message that is in a custom folder I get 4 links: This message has been sent successfully. View your submitted private message Return to your “59” folder Return to your “Inbox” folder Return to your “Outbox” folder First, only one of them probably should be labeled "return to" with the remaining links being "go to". Which link to label "return to" is a good question. I can suggest the following: if replying to a message, the folder where that message is gets "return to" link; when composing a message, all folders are "go to" linked. Second, the inbox link in this case feels cluttering. What would be a use case for it?
        Hide
        nickvergessen Joas Schilling added a comment - - edited

        I added a new language string "Go to folder" and changed the return links a bit:

        If you reply,quote,forward, you get the following links:

        • message
        • [custom folder]
        • inbox

        If you compose, edit a message:

        • message
        • [custom folder]
        • outbox
        Show
        nickvergessen Joas Schilling added a comment - - edited I added a new language string "Go to folder" and changed the return links a bit: If you reply,quote,forward, you get the following links: message [custom folder] inbox If you compose, edit a message: message [custom folder] outbox

          People

          • Assignee:
            nickvergessen Joas Schilling
            Reporter:
            DavidIQ David Colón
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development