Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10157

Missing error handling when a custom profile field is not defined for current language

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.8
    • Fix Version/s: 3.0.10-RC1
    • Component/s: None
    • Labels:
      None

      Description

      Support topic: http://www.phpbb.com/community/viewtopic.php?f=46&t=2127933

      Someone mentioned elsewhere that custom profile fields are language-specific.

      Apparently the code simply assumes that each profile field is defined for the current language, which does not have to be the case if, I'm guessing, a language was added after the profile field was created. Thus it may be the case that there is no profile field definition for the current language.

      The code should report this condition in a proper fashion.

      It may be worthwhile to also add a note to the page where languages are added, if any custom profile fields are defined, that the custom profile fields need definitions for the new language.

      https://github.com/phpbb/phpbb3/blob/release-3.0.8/phpBB/includes/functions_profile_fields.php#L814

        Issue Links

          Activity

          Hide
          nickvergessen Joas Schilling added a comment -

          Well the language-strings are currently copied from the default language, so the problem from the support topic should not come up.

          However I think adding a message about the cpfs sounds reasonable and I fixed that.

          Show
          nickvergessen Joas Schilling added a comment - Well the language-strings are currently copied from the default language, so the problem from the support topic should not come up. However I think adding a message about the cpfs sounds reasonable and I fixed that.

            People

            • Assignee:
              nickvergessen Joas Schilling
              Reporter:
              Oleg Oleg [X] (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development