Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10148

Turn TEMPLATE_BITFIELD into an instance variable in acp_styles.php

    Details

    • Type: Improvement
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.8
    • Fix Version/s: 3.1.0-a1
    • Component/s: ACP
    • Labels:
      None

      Description

      acp_styles.php has this code:

      		define('TEMPLATE_BITFIELD', $bitfield->get_base64());
      

      This prevents more than one style to be refreshed in a single script invocation if the most obvious approach to doing so is taken (which is multiple instantiations of acp_styles class).

      I do not see any reason why this should be a global define, therefore the proposal is to make it an instance variable instead.

        Activity

        There are no comments yet on this issue.

          People

          • Assignee:
            Oleg Oleg [X] (Inactive)
            Reporter:
            Oleg Oleg [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development