Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10129

Missing apostrophes in ACP user management -> permissions

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0.8
    • Fix Version/s: 3.0.11-RC1
    • Component/s: ACP
    • Labels:
      None

      Description

      1. Go to acp.
      2. Select 'users and groups' on top.
      3. Select 'manage users' on the sidebar.
      4. Enter 'admin'.
      5. Select 'permissions' from the dropdown on the right.

      Observe the following:

      » Set users permissions
      » Set users forum permissions

      Both of those rows are missing apostrophes, probably "user's" is what was intended.

        Activity

        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        thinkagain, the change being proposed here is intended to improve usability. I am still a rather novice user of acp, and as such a user this change would have helped me accomplish what I wanted to do quicker and with less frustration.

        Usability of acp is a known issue. It is something that had been brought up many times by different users. It is in fact an improvement scheduled for 3.1.

        Fixing (or improving) language in acp has not gathered anywhere near as much demand. More specifically I cannot recall users bringing it up as an issue at all. If you believe it is an issue we have a process for suggesting and implementing improvements to phpbb that you can follow.

        Show
        Oleg Oleg [X] (Inactive) added a comment - thinkagain, the change being proposed here is intended to improve usability. I am still a rather novice user of acp, and as such a user this change would have helped me accomplish what I wanted to do quicker and with less frustration. Usability of acp is a known issue. It is something that had been brought up many times by different users. It is in fact an improvement scheduled for 3.1. Fixing (or improving) language in acp has not gathered anywhere near as much demand. More specifically I cannot recall users bringing it up as an issue at all. If you believe it is an issue we have a process for suggesting and implementing improvements to phpbb that you can follow.
        Hide
        stevemaury stevemaury added a comment - - edited

        My input was requested, so here it is. "Group permissions" and "User permissions" are fine for the globals, but when we get to Forum-based permissions, not so much. Those links allow you to set the permissions of any or all users (albeit one at a time) or any or all Groups (albeit one at a time). Therefore, the link's names should be "Users' forum permissions" and "Groups' forum permissions". To be consistent then, the globals should be "Groups' permissions" and Users' permissions". FWIW

        Show
        stevemaury stevemaury added a comment - - edited My input was requested, so here it is. "Group permissions" and "User permissions" are fine for the globals, but when we get to Forum-based permissions, not so much. Those links allow you to set the permissions of any or all users (albeit one at a time) or any or all Groups (albeit one at a time). Therefore, the link's names should be "Users' forum permissions" and "Groups' forum permissions". To be consistent then, the globals should be "Groups' permissions" and Users' permissions". FWIW
        Hide
        thinkagain thinkagain [X] (Inactive) added a comment - - edited

        You just disproved your own position with the context you acknowledged above. "Those links allow you to set the permissions of any or all users (albeit one at a time) or any or all Groups (albeit one at a time). "
        The one at a time is the context thus there is no plural and certainly no plural possessive. If the interface those links took you to allowed the management of multiple users/groups at at time then the plural would apply but the fact that only one user or one group can be managed at a time leaves it in the singular context and since it can be any user or any group no specific noun thus no possessive. The context is the same for Forum Based Permissions as for Global Permissions. I have attempted to use this system's wiki markup to correct the existing language as it is presented on each of those screens:

        User forum permissions
        Here you can assign forum permissions to individual users.

        Group forum permissions
        Here you can assign forum permissions to individual groups.

        edit: wiki markup appears to be problematic so I have changed them to what they should be rather than showing what I deleted and inserted.

        Show
        thinkagain thinkagain [X] (Inactive) added a comment - - edited You just disproved your own position with the context you acknowledged above. "Those links allow you to set the permissions of any or all users (albeit one at a time) or any or all Groups (albeit one at a time) . " The one at a time is the context thus there is no plural and certainly no plural possessive. If the interface those links took you to allowed the management of multiple users/groups at at time then the plural would apply but the fact that only one user or one group can be managed at a time leaves it in the singular context and since it can be any user or any group no specific noun thus no possessive. The context is the same for Forum Based Permissions as for Global Permissions. I have attempted to use this system's wiki markup to correct the existing language as it is presented on each of those screens: User forum permissions Here you can assign forum permissions to individual users. Group forum permissions Here you can assign forum permissions to individual groups. edit: wiki markup appears to be problematic so I have changed them to what they should be rather than showing what I deleted and inserted.
        Hide
        naderman Nils Adermann added a comment -

        The version without any apostrophes should be used. We need a new patch.

        Show
        naderman Nils Adermann added a comment - The version without any apostrophes should be used. We need a new patch.
        Hide
        harderthanfire harderthanfire added a comment -

        Here is the new patch for this ticket.

        Show
        harderthanfire harderthanfire added a comment - Here is the new patch for this ticket.

          People

          • Assignee:
            imkingdavid David King
            Reporter:
            Oleg Oleg [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development