Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10103

Fix remaining usage of flock() by converting it to use the lock class

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.8
    • Fix Version/s: 3.1.0-a1
    • Component/s: None
    • Labels:
      None

      Issue Links

        Activity

        Hide
        Oleg Oleg [X] (Inactive) added a comment - - edited

        I don't know if we can actually do this for cache and template engine.

        pie@jungle phpbb % git grep flock
        phpBB/includes/cache/driver/file.php: @flock($handle, LOCK_EX);
        phpBB/includes/cache/driver/file.php: @flock($handle, LOCK_UN);
        phpBB/includes/functions_messenger.php: @flock($lock_fp, LOCK_EX);
        phpBB/includes/functions_messenger.php: @flock($lock_fp, LOCK_UN);
        phpBB/includes/template/compile.php: @flock($destination_handle, LOCK_EX);
        phpBB/includes/template/compile.php: @flock($destination_handle, LOCK_UN);

        Show
        Oleg Oleg [X] (Inactive) added a comment - - edited I don't know if we can actually do this for cache and template engine. pie@jungle phpbb % git grep flock phpBB/includes/cache/driver/file.php: @flock($handle, LOCK_EX); phpBB/includes/cache/driver/file.php: @flock($handle, LOCK_UN); phpBB/includes/functions_messenger.php: @flock($lock_fp, LOCK_EX); phpBB/includes/functions_messenger.php: @flock($lock_fp, LOCK_UN); phpBB/includes/template/compile.php: @flock($destination_handle, LOCK_EX); phpBB/includes/template/compile.php: @flock($destination_handle, LOCK_UN);
        Hide
        EXreaction EXreaction [X] (Inactive) added a comment -

        There is now one .lock file for every cache file in the cache directory, is this intended?

        If so, the .gitignore needs to be updated to ignore these files.

        Show
        EXreaction EXreaction [X] (Inactive) added a comment - There is now one .lock file for every cache file in the cache directory, is this intended? If so, the .gitignore needs to be updated to ignore these files.
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        Yes and yes.

        Show
        Oleg Oleg [X] (Inactive) added a comment - Yes and yes.

          People

          • Assignee:
            Oleg Oleg [X] (Inactive)
            Reporter:
            Oleg Oleg [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development