Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10068

Firefox4 restrictions to :visited

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0.8
    • Fix Version/s: 3.0.9-RC1
    • Component/s: Styles
    • Labels:
      None
    • Environment:
      Firefox 4.0.x

      Description

      Firefox is going to have some restrictions on :visisted elements:
      http://hacks.mozilla.org/2010/03/privacy-related-changes-coming-to-css-vistited/

      We're limiting the CSS properties that can be used to style visited links to color, background-color, border-*-color, and outline-color and the color parts of the fill and stroke properties.

      I searched through the stylesheets of prosilver to see where this touches phpbb and just found one issue:
      Links in posts won't be underlined with dots anymore:

      .postlink:visited {
      	color: #bdbdbd;
      	border-bottom-style: dotted;
      	border-bottom-color: #666666;
      }

      Personally, I would just remove the border-style and adjust the color so it fits prosilver-blue instead of being grey.
      This would make links with [url] and without look the same, what I think should have happened long time ago.

        Activity

        Hide
        naderman Nils Adermann added a comment -

        Am I missing something here? The suggested fix seems to just get rid of any and all distinction altogether?

        Show
        naderman Nils Adermann added a comment - Am I missing something here? The suggested fix seems to just get rid of any and all distinction altogether?
        Hide
        naderman Nils Adermann added a comment -

        It also gets rid of the general hover background without any good reason?

        Show
        naderman Nils Adermann added a comment - It also gets rid of the general hover background without any good reason?
        Hide
        nickvergessen Joas Schilling added a comment -

        Fixed the pull request to just reflect the changes I posted in the ticket here.

        I personally would like it, when links in the signature and in the posts look pretty much the same.
        But that can be handled in another ticket later.

        Show
        nickvergessen Joas Schilling added a comment - Fixed the pull request to just reflect the changes I posted in the ticket here. I personally would like it, when links in the signature and in the posts look pretty much the same. But that can be handled in another ticket later.

          People

          • Assignee:
            nickvergessen Joas Schilling
            Reporter:
            nickvergessen Joas Schilling
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development