Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
3.0.8
-
None
Description
After applying fixes in PHPBB3-10049 there is the following error:
area% ~pie/apps/thirdparty/run.sh tests/session/*p
|
PHPUnit @package_version@ by Sebastian Bergmann.
|
|
|
F.
|
|
|
Time: 0 seconds, Memory: 11.50Mb
|
|
|
There was 1 failure:
|
|
|
1) phpbb_session_continue_test::test_session_begin_valid_session with data set #0 ('bar_session', '4', 'user agent', array(array('anon_session', 1), array('bar_session', 4)), array(), 'Check if no new session was created')
|
Check if no new session was created
|
Failed asserting that two arrays are equal.
|
--- Expected
|
+++ Actual
|
@@ @@
|
|
+ [2] => Array
|
+ (
|
+ [session_id] => 8f3f2db18d70964c38bd2821f8f292c5
|
+ [session_user_id] => 1
|
+ )
|
+
|
)
|
|
|
|
|
FAILURES!
|
Tests: 2, Assertions: 5, Failures: 1.
|
|
With that test marked pending, running the complete suite fails the init test:
area% ~pie/apps/thirdparty/run.sh
|
PHPUnit @package_version@ by Sebastian Bergmann.
|
|
|
............................................................... 63 / 871 ( 7%)
|
............................................................... 126 / 871 ( 14%)
|
............................................................... 189 / 871 ( 21%)
|
............................................................... 252 / 871 ( 28%)
|
..................................................SSSSSSSSSSSSS 315 / 871 ( 36%)
|
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSIIF.................. 378 / 871 ( 43%)
|
............................................................... 441 / 871 ( 50%)
|
............................................................... 504 / 871 ( 57%)
|
............................................................... 567 / 871 ( 65%)
|
............................................................... 630 / 871 ( 72%)
|
............................................................... 693 / 871 ( 79%)
|
............................................................... 756 / 871 ( 86%)
|
............................................................... 819 / 871 ( 94%)
|
......................................
|
|
|
Time: 22 seconds, Memory: 34.75Mb
|
|
|
There was 1 failure:
|
|
|
1) phpbb_session_init_test::test_login_session_create
|
Check if exacly one session for user id 3 was created
|
Failed asserting that two arrays are equal.
|
--- Expected
|
+++ Actual
|
@@ @@
|
Array
|
(
|
[0] => Array
|
(
|
+ [session_user_id] => 1
|
+ )
|
+
|
+ [1] => Array
|
+ (
|
+ [session_user_id] => 4
|
+ )
|
+
|
+ [2] => Array
|
+ (
|
[session_user_id] => 3
|
)
|
|
)
|
|
|
|
|
FAILURES!
|
Tests: 857, Assertions: 9912, Failures: 1, Incomplete: 2, Skipped: 55.
|
However the init test by itself succeeds:
area% ~pie/apps/thirdparty/run.sh tests/session/init_test.php
|
PHPUnit @package_version@ by Sebastian Bergmann.
|
|
|
.
|
|
|
Time: 0 seconds, Memory: 11.25Mb
|
|
|
OK (1 test, 7 assertions)
|
Attachments
Issue Links
- blocks
-
PHPBB3-9732 Cover session code extensively in tests
-
- Unverified Fix
-
- depends on
-
-
- Closed
-