Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.8
    • Fix Version/s: 3.0.9-RC1
    • Component/s: Test Suite
    • Labels:
      None

      Description

      After applying fixes in PHPBB3-10049 there is the following error:

      area% ~pie/apps/thirdparty/run.sh tests/session/*p
      PHPUnit @package_version@ by Sebastian Bergmann.
       
      F.
       
      Time: 0 seconds, Memory: 11.50Mb
       
      There was 1 failure:
       
      1) phpbb_session_continue_test::test_session_begin_valid_session with data set #0 ('bar_session', '4', 'user agent', array(array('anon_session', 1), array('bar_session', 4)), array(), 'Check if no new session was created')
      Check if no new session was created
      Failed asserting that two arrays are equal.
      --- Expected
      +++ Actual
      @@ @@
       
      +    [2] => Array
      +        (
      +            [session_id] => 8f3f2db18d70964c38bd2821f8f292c5
      +            [session_user_id] => 1
      +        )
      +
       )
       
       
      FAILURES!
      Tests: 2, Assertions: 5, Failures: 1.
      
      

      With that test marked pending, running the complete suite fails the init test:

      area% ~pie/apps/thirdparty/run.sh
      PHPUnit @package_version@ by Sebastian Bergmann.
       
      ...............................................................  63 / 871 (  7%)
      ............................................................... 126 / 871 ( 14%)
      ............................................................... 189 / 871 ( 21%)
      ............................................................... 252 / 871 ( 28%)
      ..................................................SSSSSSSSSSSSS 315 / 871 ( 36%)
      SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSIIF.................. 378 / 871 ( 43%)
      ............................................................... 441 / 871 ( 50%)
      ............................................................... 504 / 871 ( 57%)
      ............................................................... 567 / 871 ( 65%)
      ............................................................... 630 / 871 ( 72%)
      ............................................................... 693 / 871 ( 79%)
      ............................................................... 756 / 871 ( 86%)
      ............................................................... 819 / 871 ( 94%)
      ......................................
       
      Time: 22 seconds, Memory: 34.75Mb
       
      There was 1 failure:
       
      1) phpbb_session_init_test::test_login_session_create
      Check if exacly one session for user id 3 was created
      Failed asserting that two arrays are equal.
      --- Expected
      +++ Actual
      @@ @@
       Array
       (
           [0] => Array
               (
      +            [session_user_id] => 1
      +        )
      +
      +    [1] => Array
      +        (
      +            [session_user_id] => 4
      +        )
      +
      +    [2] => Array
      +        (
                   [session_user_id] => 3
               )
       
       )
       
       
      FAILURES!
      Tests: 857, Assertions: 9912, Failures: 1, Incomplete: 2, Skipped: 55.
      

      However the init test by itself succeeds:

      area% ~pie/apps/thirdparty/run.sh tests/session/init_test.php 
      PHPUnit @package_version@ by Sebastian Bergmann.
       
      .
       
      Time: 0 seconds, Memory: 11.25Mb
       
      OK (1 test, 7 assertions)
      

        Issue Links

          Activity

          Hide
          Oleg Oleg [X] (Inactive) added a comment -

          The error above was with sqlite.

          Show
          Oleg Oleg [X] (Inactive) added a comment - The error above was with sqlite.
          Hide
          Oleg Oleg [X] (Inactive) added a comment - - edited

          This was not merged into develop, and simple merge of develop-olympus into develop now breaks tests:

          area% ~pie/apps/thirdparty/run.sh
          PHPUnit @package_version@ by Sebastian Bergmann.
           
          .............................................................   61 / 1049 (  5%)
          .............................................................  122 / 1049 ( 11%)
          .............................................................  183 / 1049 ( 17%)
          .............................................................  244 / 1049 ( 23%)
          .............................................................  305 / 1049 ( 29%)
          ..........................................................III  366 / 1049 ( 34%)
          IIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIPHP Fatal error:  Call to a member function is_set() on a non-object in /home/pie/apps/thirdparty/phpbb/phpBB/includes/session.php on line 245
           
          Fatal error: Call to a member function is_set() on a non-object in /home/pie/apps/thirdparty/phpbb/phpBB/includes/session.php on line 245
          

          Show
          Oleg Oleg [X] (Inactive) added a comment - - edited This was not merged into develop, and simple merge of develop-olympus into develop now breaks tests: area% ~pie/apps/thirdparty/run.sh PHPUnit @package_version@ by Sebastian Bergmann.   ............................................................. 61 / 1049 ( 5%) ............................................................. 122 / 1049 ( 11%) ............................................................. 183 / 1049 ( 17%) ............................................................. 244 / 1049 ( 23%) ............................................................. 305 / 1049 ( 29%) ..........................................................III 366 / 1049 ( 34%) IIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIIPHP Fatal error: Call to a member function is_set() on a non-object in /home/pie/apps/thirdparty/phpbb/phpBB/includes/session.php on line 245   Fatal error: Call to a member function is_set() on a non-object in /home/pie/apps/thirdparty/phpbb/phpBB/includes/session.php on line 245
          Hide
          naderman Nils Adermann added a comment -

          Yes, they were merged. Runs fine here. Did you forget to pull?

          Show
          naderman Nils Adermann added a comment - Yes, they were merged. Runs fine here. Did you forget to pull?
          Hide
          Oleg Oleg [X] (Inactive) added a comment -

          I probably did not update my develop branch properly.

          Show
          Oleg Oleg [X] (Inactive) added a comment - I probably did not update my develop branch properly.

            People

            • Assignee:
              naderman Nils Adermann
              Reporter:
              Oleg Oleg [X] (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development