Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10049

Session test files are misnamed, session tests are not run

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.0.8
    • Fix Version/s: 3.0.9-RC1
    • Component/s: Test Suite
    • Labels:
      None

      Description

      These files do not end in _test.php (per phpunit.xml.dist) and are never executed by phpunit.

      tests/session/session_continue.php
      tests/session/session_init.php

      Furthermore, they try to include nonexistent files in test_framework, which makes them not work when manually invoked.

        Issue Links

          Activity

          Hide
          Oleg Oleg [X] (Inactive) added a comment - - edited

          Note that with the fix here the test suite would produce one error, which is covered by PHPBB3-10052.

          Edit: fixed/worked around this - see follow-up comment.

          Show
          Oleg Oleg [X] (Inactive) added a comment - - edited Note that with the fix here the test suite would produce one error, which is covered by PHPBB3-10052. Edit: fixed/worked around this - see follow-up comment.
          Hide
          Oleg Oleg [X] (Inactive) added a comment -

          Note that both session tests fail (in different ways). I marked them incomplete with additional commits. Proper fixes are covered by PHPBB3-10052.

          Show
          Oleg Oleg [X] (Inactive) added a comment - Note that both session tests fail (in different ways). I marked them incomplete with additional commits. Proper fixes are covered by PHPBB3-10052.
          Hide
          brunoais brunoais added a comment -

          Names refered here are correct.

          Show
          brunoais brunoais added a comment - Names refered here are correct.

            People

            • Assignee:
              Oleg Oleg [X] (Inactive)
              Reporter:
              Oleg Oleg [X] (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development