Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10033

"Disallow usernames" does not check already disallowed names

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 3.0.8
    • Fix Version/s: 3.0.9-RC1
    • Component/s: ACP
    • Labels:
      None

      Description

      The description on the Disallow usernames page of a board's Admin Panel states "Please note that you will not be allowed to specify any username that has already been registered, you must first delete that name then disallow it." This is not true. If "tester_2" is registered, that username can still be disallowed. There is no check performed against registered usernames in acp_disallow.php.

      The description is stored as ACP_DISALLOW_EXPLAIN in language/en/acp/posting.php. It should probably be altered in a future version.

        Activity

        Hide
        nickvergessen Joas Schilling added a comment -

        It also did not check whether you disallowed the same username before.
        I know changed it so it checks for usernames and already disallowed ones.

        Show
        nickvergessen Joas Schilling added a comment - It also did not check whether you disallowed the same username before. I know changed it so it checks for usernames and already disallowed ones.
        Hide
        nickvergessen Joas Schilling added a comment -

        As per discussion on github it seems to make sense to allow disallowing registered usernames for bantu and nn-:
        https://github.com/phpbb/phpbb3/pull/94#issuecomment-847500

        I personally think that it is a good idea, after I read that.

        Show
        nickvergessen Joas Schilling added a comment - As per discussion on github it seems to make sense to allow disallowing registered usernames for bantu and nn-: https://github.com/phpbb/phpbb3/pull/94#issuecomment-847500 I personally think that it is a good idea, after I read that.

          People

          • Assignee:
            nickvergessen Joas Schilling
            Reporter:
            Thoul Thoul [X] (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development