Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-10011

__DIR__ in test suite renders it unusable on php < 5.3

    Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.0.8
    • Fix Version/s: 3.0.9-RC1
    • Component/s: Test Suite
    • Labels:
      None

      Description

      Note that even develop-olympus has a number of uses of _DIR_.

        Issue Links

          Activity

          Hide
          Oleg Oleg [X] (Inactive) added a comment -

          Note that PHPBB3-10013 alters one _DIR_ into a _FILE_.

          Show
          Oleg Oleg [X] (Inactive) added a comment - Note that PHPBB3-10013 alters one _ DIR _ into a _ FILE _.
          Hide
          Erik Frèrejean Erik Frèrejean added a comment -

          Something got messed up in #52

          Show
          Erik Frèrejean Erik Frèrejean added a comment - Something got messed up in #52
          Hide
          bantu Andreas Fischer added a comment -

          Need to update the leftovers from develop as well.

          Show
          bantu Andreas Fischer added a comment - Need to update the leftovers from develop as well.
          Hide
          Erik Frèrejean Erik Frèrejean added a comment -

          Ah sorry, created an other pull request. I wasn't sure on how to handle the changes that also get applied in: http://tracker.phpbb.com/browse/PHPBB3-10013. So I've included them here as well.

          Show
          Erik Frèrejean Erik Frèrejean added a comment - Ah sorry, created an other pull request. I wasn't sure on how to handle the changes that also get applied in: http://tracker.phpbb.com/browse/PHPBB3-10013 . So I've included them here as well.
          Hide
          Erik Frèrejean Erik Frèrejean added a comment -

          Added the other Ascraeus tests.

          Show
          Erik Frèrejean Erik Frèrejean added a comment - Added the other Ascraeus tests.
          Hide
          naderman Nils Adermann added a comment -

          See failed Bamboo build for details.

          Show
          naderman Nils Adermann added a comment - See failed Bamboo build for details.
          Hide
          naderman Nils Adermann added a comment -
          Show
          naderman Nils Adermann added a comment - First fix at: https://github.com/phpbb/phpbb3/pull/53

            People

            • Assignee:
              bantu Andreas Fischer
              Reporter:
              Oleg Oleg [X] (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development