Details

    • Type: Bug
    • Status: Unverified Fix
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.0-dev
    • Fix Version/s: 3.1.0-a1
    • Component/s: Other
    • Labels:
      None
    • Environment:
      Not environment specific

      Description

      As per IRC, if you try to unset something that is stored inside the new phpbb_config class, the class will throw an error:
      "Config values have to be deleted explicitly with the phpbb_config::delete($key) method."
      There however isn't a phpbb_config::delete($key) method in the class.

        Activity

        Hide
        bantu Andreas Fischer added a comment -

        Good catch.

        Show
        bantu Andreas Fischer added a comment - Good catch.
        Hide
        Erik Frèrejean Erik Frèrejean added a comment -

        Proposed implementation for the missing method. I hope that the tests are correctly.

        Show
        Erik Frèrejean Erik Frèrejean added a comment - Proposed implementation for the missing method. I hope that the tests are correctly.
        Hide
        Oleg Oleg [X] (Inactive) added a comment -

        Rebased patch on develop so that I could run the tests.

        Show
        Oleg Oleg [X] (Inactive) added a comment - Rebased patch on develop so that I could run the tests.
        Hide
        naderman Nils Adermann added a comment -

        Patch looks good to me.

        Show
        naderman Nils Adermann added a comment - Patch looks good to me.

          People

          • Assignee:
            Oleg Oleg [X] (Inactive)
            Reporter:
            Erik Frèrejean Erik Frèrejean
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development