Details

      Description

      Conversion of all Forum & Topic images through the template from in-line styles to CSS classes.

      Involves creating template variable to house $folder_img and basing the class naming off of these

      'TOPIC_IMG_STYLE' => $folder_img,

      <dl class="icon

      {topicrow.TOPIC_IMG_STYLE}

      ">

      Files affected

      functions_display.php
      mcp_forum.php
      ucp_main.php
      ucp_pm_viewfolder.php
      search.php
      viewforum.php

      forumlist_body.html
      mcp_forum.html
      search_results.html
      ucp_main_bookmarks.html
      ucp_main_subscribed.html
      ucp_main_front.html
      ucp_pm_viewfolder.html
      viewforum_body.html

        Activity

        Hide
        Hanakin Michael Miday added a comment -

        I have tested it on my end and everything seems to work flawlessly, however not sure if all the variables in the back-end are required I just did a search for all uses of folder_img_src and added the new variables to those arrays

        Show
        Hanakin Michael Miday added a comment - I have tested it on my end and everything seems to work flawlessly, however not sure if all the variables in the back-end are required I just did a search for all uses of folder_img_src and added the new variables to those arrays
        Hide
        ckwalsh Cullen Walsh [X] (Inactive) added a comment -

        I haven't checked this thoroughly yet (just about to hit the sack) but I like this approach a lot.

        The one problem I see however is the missing background-position attribute for these instances.

        Show
        ckwalsh Cullen Walsh [X] (Inactive) added a comment - I haven't checked this thoroughly yet (just about to hit the sack) but I like this approach a lot. The one problem I see however is the missing background-position attribute for these instances.
        Hide
        Hanakin Michael Miday added a comment -

        the background-repeat:no-repeat is already handled via the .icon classes so its inclusion in the original files was obsolete I have verified this in firebug.

        Show
        Hanakin Michael Miday added a comment - the background-repeat:no-repeat is already handled via the .icon classes so its inclusion in the original files was obsolete I have verified this in firebug.
        Hide
        igorw Igor Wiedler [X] (Inactive) added a comment -

        This is going into 3.1.

        Show
        igorw Igor Wiedler [X] (Inactive) added a comment - This is going into 3.1.

          People

          • Assignee:
            igorw Igor Wiedler [X] (Inactive)
            Reporter:
            Hanakin Michael Miday
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development