Uploaded image for project: 'phpBB'
  1. phpBB
  2. PHPBB-9673 Compatibility with HipHop
  3. PHPBB-9671

Replace preg_replace with /e modifier with preg_replace_callback in includes/message_parser.php

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Invalid
    • Icon: Major Major
    • 3.1.0-b4
    • 3.0.7-PL1
    • None
    • None

      includes/message_parser.php uses preg_replace with the /e modifier, which evals the result before replacing. This is inefficient and breaks compatibility with HipHop. This patch removes those cases and replaces them with two callbacks.

            nickvergessen Joas Schilling
            ckwalsh Cullen Walsh [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: