Uploaded image for project: 'phpBB'
  1. phpBB
  2. PHPBB-14873

Missing width and height variables for smilies

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • 3.2.0-RC2
    • 3.1.10, 3.2.0-RC1
    • Posting

      I've create a smilies pack and I've a problem when posting the smile. The image on server has 72px.
      And since its 225 images I dont want to change all to 20px.
      But I've put on the .pak 20px for the size of it. On the smilies box it appears very well, since the HTML is using the size is on the database. But after posting it appears at 72px.

      I've found the problem on root/includes/functions_content.php line 992:

      return preg_replace('#<!\-\- s(.*?) \-\-><img src="\{SMILIES_PATH\}\/(.*?) \/><!\-\- s\1 \-\->#', '<img class="smilies" src="' . $root_path . $config['smilies_path'] . '/\2 />', $text);
      

      And it should be like this:

      return preg_replace('#<!\-\- s(.*?) \-\-><img src="\{SMILIES_PATH\}\/(.*?) \/><!\-\- s\1 \-\->#', '<img class="smilies" width="??px" height="??px" src="' . $root_path . $config['smilies_path'] . '/\2 />', $text);
      

      It miss the width and height value with the variable there.

            Marc Marc
            Tarantino Tarantino
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: