Uploaded image for project: 'phpBB'
  1. phpBB
  2. PHPBB-10148

Turn TEMPLATE_BITFIELD into an instance variable in acp_styles.php

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.1.0-a1
    • 3.0.8
    • ACP
    • None

      acp_styles.php has this code:

      		define('TEMPLATE_BITFIELD', $bitfield->get_base64());
      

      This prevents more than one style to be refreshed in a single script invocation if the most obvious approach to doing so is taken (which is multiple instantiations of acp_styles class).

      I do not see any reason why this should be a global define, therefore the proposal is to make it an instance variable instead.

            Oleg Oleg [X] (Inactive)
            Oleg Oleg [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: