phpBB3

Support for sqlite version 3

Details

Description

Partially discussed in http://area51.phpbb.com/phpBB/viewtopic.php?p=210819#p210819

Sqlite 3 wasn't available when phpBB 3.0.x was released, but it has some functionality over sqlite 2 that could be used. Also see: http://area51.phpbb.com/phpBB/viewtopic.php?p=210900#p210900

Issue Links

blocks

Improvement - An improvement or enhancement to an existing feature or task. PHPBB3-8674 Sqlite and AUTOINCREMENT

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Open - The issue is open and ready for the assignee to start work on it.
depends on

Task - A task that needs to be done. PHPBB3-10003 Resolve db_tools proliferation

  • Major - Major loss of function.
  • Unverified Fix - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.
is duplicated by

New Feature - A new feature of the product, which has yet to be developed. PHPBB3-9736 Support of SQLite 3.0+

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Andreas Fischer made changes -
Field Original Value New Value
Link This issue blocks PHPBB3-8674 [ PHPBB3-8674 ]
Ruslan Uzdenov made changes -
Link This issue is duplicated by PHPBB3-9736 [ PHPBB3-9736 ]
Hide
Permalink
Igor Wiedler added a comment -

RFC: http://area51.phpbb.com/phpBB/viewtopic.php?f=84&t=33447

Show
Igor Wiedler added a comment - RFC: http://area51.phpbb.com/phpBB/viewtopic.php?f=84&t=33447
Igor Wiedler made changes -
Assignee Igor Wiedler [ igorw ]
Hide
Permalink
Chris Smith added a comment -

I'm working on pulling the MOD into a branch.

Show
Chris Smith added a comment - I'm working on pulling the MOD into a branch.
Chris Smith made changes -
Assignee Igor Wiedler [ igorw ] Chris Smith [ ToonArmy ]
Hide
Permalink
Chris Smith added a comment -

Various complications should be resolved with db_tools before making a bigger mess with this feature. Hence I won't be updating the updater db_tools in my branch.

Show
Chris Smith added a comment - Various complications should be resolved with db_tools before making a bigger mess with this feature. Hence I won't be updating the updater db_tools in my branch.
Chris Smith made changes -
Link This issue depends on PHPBB3-10003 [ PHPBB3-10003 ]
Hide
Permalink
Chris Smith added a comment -

Work has started: https://github.com/cs278/phpbb3/compare/develop...feature/sqlite3

Show
Chris Smith added a comment - Work has started: https://github.com/cs278/phpbb3/compare/develop...feature/sqlite3
Hide
Permalink
Igor Wiedler added a comment -

Here's a version that passes almost all tests, except for one with null bytes.

https://github.com/igorw/phpbb3/compare/ticket%2F9728

The problem is the same that is fixed here: https://github.com/rails/rails/commit/88636f7195fc936421392740f980d17ebe77d701

Fixing it may however be non-trivial.

Show
Igor Wiedler added a comment - Here's a version that passes almost all tests, except for one with null bytes. https://github.com/igorw/phpbb3/compare/ticket%2F9728 The problem is the same that is fixed here: https://github.com/rails/rails/commit/88636f7195fc936421392740f980d17ebe77d701 Fixing it may however be non-trivial.
Hide
Permalink
Igor Wiedler added a comment -

Related (and partial fix): https://gist.github.com/1076914

Show
Igor Wiedler added a comment - Related (and partial fix): https://gist.github.com/1076914
Hide
Permalink
Joas Schilling added a comment -

After some research tonight, I came to the conclusion that we need to give the column_type or column_name&table_name (so we can determinate the type) to sql_escape, so we can find out whether its binary data that is going to be handled or not. This however should be optional, so you can still use $db->sql_escape() as it works today.

I'd suggest to add a parameter $is_binary = false to sql_escape() and set this properly within _sql_validate_value(), therefore we need to either pass the column_name&table_name or column_type to that function aswell. I'd suggest to use the column_type here.

However if we want to fix this, we need to specify the table on sql_build_array()and sql_in_set(),[sql_multi_insert() already has it] if it can contain binary data.

I will try to turn my idea into a patch later today or tomorrow, so we can see whether its too much or not.

Show
Joas Schilling added a comment - After some research tonight, I came to the conclusion that we need to give the column_type or column_name&table_name (so we can determinate the type) to sql_escape, so we can find out whether its binary data that is going to be handled or not. This however should be optional, so you can still use $db->sql_escape() as it works today. I'd suggest to add a parameter $is_binary = false to sql_escape() and set this properly within _sql_validate_value(), therefore we need to either pass the column_name&table_name or column_type to that function aswell. I'd suggest to use the column_type here. However if we want to fix this, we need to specify the table on sql_build_array()and sql_in_set(), [sql_multi_insert() already has it] if it can contain binary data. I will try to turn my idea into a patch later today or tomorrow, so we can see whether its too much or not.
Hide
Permalink
Joas Schilling added a comment -

Well so the problem is, sql_escape can not handle binary in sqlite3, as it needs to add an x before the '' in the query, so we would need to include the ' into the function, I would suggest using a new function sql_escape_binary() https://gist.github.com/1078063

But the problem with terminating whether a column is binary or not, is still a problem which might lead to big code changes.

Show
Joas Schilling added a comment - Well so the problem is, sql_escape can not handle binary in sqlite3, as it needs to add an x before the '' in the query, so we would need to include the ' into the function, I would suggest using a new function sql_escape_binary() https://gist.github.com/1078063 But the problem with terminating whether a column is binary or not, is still a problem which might lead to big code changes.
shibulijack made changes -
Status Open [ 1 ] Unreviewed Patch [ 10002 ]
Proposed Patch URL https://github.com/phpbb/phpbb3/pull/666
Proposed Patch Location URL [ 10012 ]
shibulijack made changes -
Comment [ I have tried to add support for sqlite3 by analysing the mod "Support of SQLite 3.0+" by Boris Berdichevski. Passes the travis test. ]
Hide
Permalink
shibulijack added a comment -

Can someone please review this PR: https://github.com/phpbb/phpbb3/pull/666
Passes the travis test.

Show
shibulijack added a comment - Can someone please review this PR: https://github.com/phpbb/phpbb3/pull/666 Passes the travis test.
Nils Adermann made changes -
Workflow phpBB Full Tracker Workflow 2 [ 38703 ] phpBB Full Tracker Workflow 3 [ 50285 ]
Joas Schilling made changes -
Status Patch Awaiting Review [ 10002 ] Patch Needs Work [ 10004 ]

People

  • Assignee:
    Chris Smith
    Reporter:
    Andreas Fischer
Vote (0)
Watch (0)

Dates

  • Created:
    Updated: