phpBB3

MSSQL Schema is not azure compatible

Details

  • Type: Bug Bug
  • Status: Patch Needs Work Patch Needs Work
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 3.0.7-PL1
  • Fix Version/s: 3.0.12-RC1
  • Component/s: Database Abstraction Layer (DBAL)
  • Labels:
    None
  • Environment:
    Microsoft Azure SQL

Description

The T-SQL schema builder adds "ON" statements to the create table query, specifying the use of the default partition scheme. Azure SQL however does not support that statement.
http://msdn.microsoft.com/en-us/library/ee336258.aspx

Evaluate whether it's OK to remove the ON statements from the schema or if we need a new schema for azure.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Kellanved added a comment -

Preliminary fix.

Show
Kellanved added a comment - Preliminary fix.
Hide
Permalink
Oleg added a comment -

Commit message needs to be adjusted for current guidelines, need a pull request also.

Show
Oleg added a comment - Commit message needs to be adjusted for current guidelines, need a pull request also.
Hide
Permalink
bibin added a comment -

We removed 'ON PRIMARY' statement from the mssql script as it’s not supported in SQL azure. The 'ON PRIMARY' statement in specified in the DDL denotes the "file group" associated with that table. In SQL server there are two types of file groups:
a. Primary file group
b. User defined file group

The primary file group contains the primary data file and any other files not specifically assigned to user defined file group. In PHPBB-SQL-Schema we are not using any user defined file group, so by default all tables belongs to PRIMARY file group. This means it's usually useless and can be safely removed from the script.

Show
bibin added a comment - We removed 'ON PRIMARY' statement from the mssql script as it’s not supported in SQL azure. The 'ON PRIMARY' statement in specified in the DDL denotes the "file group" associated with that table. In SQL server there are two types of file groups: a. Primary file group b. User defined file group The primary file group contains the primary data file and any other files not specifically assigned to user defined file group. In PHPBB-SQL-Schema we are not using any user defined file group, so by default all tables belongs to PRIMARY file group. This means it's usually useless and can be safely removed from the script.

People

  • Assignee:
    Nils Adermann
    Reporter:
    Kellanved
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: