Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-9673 Compatibility with HipHop
  3. PHPBB3-9667

Replace preg_replace with /e modifier with preg_replace_callback in includes/bbcode.php

    XMLWordPrintable

Details

    • Sub-task
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Invalid
    • 3.0.7-PL1
    • 3.1.0-b4
    • None
    • None

    Description

      includes/bbcode.php uses preg_replace with the /e modifier, which evals the result before replacing. This is inefficient and breaks compatibility with HipHop. This patch removes those cases and replaces them with a callback.

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. PHPBB3-14603 Outdated call to preg_replace with e modifier breaks custom BBCode creation in HHVM and PHP 7+

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            People

              nickvergessen Joas Schilling
              ckwalsh Cullen Walsh [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: