phpBB3

Use PHP timezone handling abilities

Details

  • Type: New Feature New Feature
  • Status: Unverified Fix Unverified Fix
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 3.1-dev
  • Fix Version/s: 3.1-A1
  • Component/s: Sessions
  • Labels:
    None

Description

Implement the RFC Switch to PHP timezone handling.

Issue Links

blocks

Improvement - An improvement or enhancement to an existing feature or task. PHPBB3-10385 Specify exact end date and time for poll

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Patch Needs Work - A patch has been reviewed but needs further work before it can be merged.
depends on

Bug - A problem which impairs or prevents the functions of the product. PHPBB3-9712 Future dates display as "less than one minute ago"

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Unverified Fix - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

New Feature - A new feature of the product, which has yet to be developed. PHPBB3-10942 Add sql_case() and sql_concatenate() to dbal

  • Major - Major loss of function.
  • Unverified Fix - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Improvement - An improvement or enhancement to an existing feature or task. PHPBB3-9570 Change "system timezone" to "guest timezone" in acp, add explanation

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.
is duplicated by

Bug - A problem which impairs or prevents the functions of the product. PHPBB3-10116 Board Start affected by DST

  • Trivial - Cosmetic problem like misspelt words or misaligned text.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.
is related to

Bug - A problem which impairs or prevents the functions of the product. PHPBB3-9360 $user->format_date uses incorrect timezone for T

  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Chris Smith added a comment - 
chris@kinslayer:/media/www/phpbb.cs278.org/www/phpbb3 [feature/new-tz-handling] $ grep -Ri ">timezone" .
./phpBB/memberlist.php:			$now = getdate(time() + $user->timezone + $user->dst - date('Z'));
./phpBB/index.php:	$now = getdate(time() + $user->timezone + $user->dst - date('Z'));
./phpBB/viewtopic.php:$now = getdate(time() + $user->timezone + $user->dst - date('Z'));
./phpBB/feed.php:		$zone_offset = (int) $user->timezone + (int) $user->dst;
./phpBB/includes/functions_profile_fields.php:					return $user->format_date(gmmktime(0, 0, 0, $month, $day, $year) + $user->timezone + $user->dst, $user->lang['DATE_FORMAT'], true);
./phpBB/includes/acp/acp_board.php:		$old_tz = $user->timezone;
./phpBB/includes/acp/acp_board.php:		$user->timezone = $config['board_timezone'];
./phpBB/includes/acp/acp_board.php:		$user->timezone = $old_tz;

chris@kinslayer:/media/www/phpbb.cs278.org/www/phpbb3 [feature/new-tz-handling] $ grep -Ri ">dst" .
./phpBB/memberlist.php:			$now = getdate(time() + $user->timezone + $user->dst - date('Z'));
./phpBB/index.php:	$now = getdate(time() + $user->timezone + $user->dst - date('Z'));
./phpBB/viewtopic.php:$now = getdate(time() + $user->timezone + $user->dst - date('Z'));
./phpBB/language/en/common.php:		'dst'	=> '[ <abbr title="Daylight Saving Time">DST</abbr> ]',
./phpBB/language/en/ucp.php:	'BOARD_DST'					=> 'Summer Time/<abbr title="Daylight Saving Time">DST</abbr> is in effect',
./phpBB/language/en/acp/board.php:	'SYSTEM_DST'					=> 'Enable Summer Time/<abbr title="Daylight Saving Time">DST</abbr>',
./phpBB/feed.php:		$zone_offset = (int) $user->timezone + (int) $user->dst;
./phpBB/includes/functions_profile_fields.php:					return $user->format_date(gmmktime(0, 0, 0, $month, $day, $year) + $user->timezone + $user->dst, $user->lang['DATE_FORMAT'], true);
./phpBB/includes/acp/acp_board.php:		$old_dst = $user->dst;
./phpBB/includes/acp/acp_board.php:		$user->dst = $config['board_dst'];
./phpBB/includes/acp/acp_board.php:		$user->dst = $old_dst;
Show
Chris Smith added a comment - chris@kinslayer:/media/www/phpbb.cs278.org/www/phpbb3 [feature/ new -tz-handling] $ grep -Ri ">timezone" . ./phpBB/memberlist.php: $now = getdate(time() + $user->timezone + $user->dst - date('Z')); ./phpBB/index.php: $now = getdate(time() + $user->timezone + $user->dst - date('Z')); ./phpBB/viewtopic.php:$now = getdate(time() + $user->timezone + $user->dst - date('Z')); ./phpBB/feed.php: $zone_offset = ( int ) $user->timezone + ( int ) $user->dst; ./phpBB/includes/functions_profile_fields.php: return $user->format_date(gmmktime(0, 0, 0, $month, $day, $year) + $user->timezone + $user->dst, $user->lang['DATE_FORMAT'], true ); ./phpBB/includes/acp/acp_board.php: $old_tz = $user->timezone; ./phpBB/includes/acp/acp_board.php: $user->timezone = $config['board_timezone']; ./phpBB/includes/acp/acp_board.php: $user->timezone = $old_tz; chris@kinslayer:/media/www/phpbb.cs278.org/www/phpbb3 [feature/ new -tz-handling] $ grep -Ri ">dst" . ./phpBB/memberlist.php: $now = getdate(time() + $user->timezone + $user->dst - date('Z')); ./phpBB/index.php: $now = getdate(time() + $user->timezone + $user->dst - date('Z')); ./phpBB/viewtopic.php:$now = getdate(time() + $user->timezone + $user->dst - date('Z')); ./phpBB/language/en/common.php: 'dst' => '[ <abbr title= "Daylight Saving Time" >DST</abbr> ]', ./phpBB/language/en/ucp.php: 'BOARD_DST' => 'Summer Time/<abbr title= "Daylight Saving Time" >DST</abbr> is in effect', ./phpBB/language/en/acp/board.php: 'SYSTEM_DST' => 'Enable Summer Time/<abbr title= "Daylight Saving Time" >DST</abbr>', ./phpBB/feed.php: $zone_offset = ( int ) $user->timezone + ( int ) $user->dst; ./phpBB/includes/functions_profile_fields.php: return $user->format_date(gmmktime(0, 0, 0, $month, $day, $year) + $user->timezone + $user->dst, $user->lang['DATE_FORMAT'], true ); ./phpBB/includes/acp/acp_board.php: $old_dst = $user->dst; ./phpBB/includes/acp/acp_board.php: $user->dst = $config['board_dst']; ./phpBB/includes/acp/acp_board.php: $user->dst = $old_dst;
Hide
Permalink
Oleg added a comment -

When this is done, http://tracker.phpbb.com/browse/PHPBB3-10116 should be tested against the new code.

Show
Oleg added a comment - When this is done, http://tracker.phpbb.com/browse/PHPBB3-10116 should be tested against the new code.

People

  • Assignee:
    Joas Schilling
    Reporter:
    Chris Smith
Vote (1)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: