Uploaded image for project: 'phpBB'
  1. phpBB
  2. PHPBB-15478

core.js $loadingIndicator JavaScript errors

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.2.2-RC1
    • 3.2.1
    • JavaScript / AJAX
    • None

      Two issues with the following statement:

      $loadingIndicator = $('<div />', { 
          id: 'loading_indicator', 
          class: 'loading_indicator', 
      });
      

      1. id and class are keywords that require string delimiters if they are to be object keys according to some validators (and thus potentially some browsers).
      2. The trailing comma has compatibility issues on older browsers, and isn't used elsewhere in the codebase as far as I've looked.

            Marc Marc
            dsinn dsinn [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: