Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-13904

Refactor attachment upload functions into service

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 3.2.0-dev
    • 3.2.0-a1
    • Posting
    • None

    Description

      The attachments functions should be refactored into a service / multiple services. This should allow better coverage with unit tests and also a better extensibility in the future.

      Right now, the functions are split over several files, e.g. delete_attachments() is in functions_admin.php while upload_attachment() is in functions_posting.php.

      Attachments

        Issue Links

          is duplicated by

          Improvement - An improvement or enhancement to an existing feature or task. PHPBB3-12767 Rework functions_upload code

          • Major - Major loss of function.
          • Closed
          is related to

          New Feature - A new feature of the product, which has yet to be developed. PHPBB3-14169 Split uploaded files storage into separate class(es)

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. PHPBB3-14168 Refactor attachment management functions into classes

          • Major - Major loss of function.
          • Unverified Fix

          Activity

            People

              Marc Marc
              Marc Marc
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: