Uploaded image for project: 'phpBB'
  1. phpBB
  2. PHPBB-12162

Binary files missing from update packages

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Blocker Blocker
    • 3.0.13-RC1, 3.1.0-a3
    • 3.0.12, 3.1.0-a2
    • Build System
    • None

      When the OS locale is not set to C or en_US.UTF-8, the diff files will not be in english.
      Therefor

      			// Is binary?
      			if (preg_match('/^Binary files ' . $package_name . '\/(.*) and [a-z0-9._-]+\/\1 differ/i', $line, $match))
      			{
      				$binary[] = trim($match[1]);
      			}

      will not find the binary files and they are missing from the packages.

      We should set the locale for the diff command, so they are always english.

            nickvergessen Joas Schilling [X] (Inactive)
            nickvergessen Joas Schilling [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: