Uploaded image for project: 'phpBB'
  1. phpBB
  2. PHPBB-11444

Unnecessary notify column in phpbb_user_notifications table

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • 3.2.0-a1
    • 3.1.0-dev
    • Notification System
    • None

      The notify column in phpbb_user_notifications table seems to be unnecessary. The logic of using notify = 0 for not-subscribed and notify = 1 for subscribed is suboptimal.

      a) There is an ambiguity because no row means not-subscribed, but notify = 0 also means not-subscribed.
      b) Having unnecessary rows in the table wastes some disk space.

      The proper solution seems to be dropping the notify column and using row-exists or row-does-not-exist logic instead.

            nicofuma nicofuma
            bantu Andreas Fischer [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: