Uploaded image for project: 'phpBB3'
  1. phpBB3
  2. PHPBB3-11226

filespec::move_file() from functions_upload.php does not error correctly

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 3.0.11, 3.1.0-dev
    • 3.1.0-b4
    • Other
    • None

    Description

      If $overwrite is false and the the destination file exists, no error message is given, file_moved is set to true and the return value is true.
      All 3 of these results are wrong.
      It should add an error message to ->error, file_moved should not be set to true and return should be false.

      Attachments

        Activity

          People

            nickvergessen Joas Schilling
            nickvergessen Joas Schilling
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: