phpBB3

Add permission to the ACP GUI page

Details

  • Type: Sub-task Sub-task
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 3.1-dev
  • Fix Version/s: 3.1-A1
  • Component/s: ACP
  • Labels:
    None

Description

This requires:

  • Changing the files so that this option appears.
  • Add javascript code so that the permission disappears when it does not apply.
  • Add text to language file so that it appears in the ACP.

Issue Links

blocks

Improvement - An improvement or enhancement to an existing feature or task. PHPBB3-10623 New Forum permission. Only OP can view

  • Major - Major loss of function.
  • Patch Needs Work - A patch has been reviewed but needs further work before it can be merged.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
brunoais added a comment -

Commit done.
1st part:https://github.com/brunoais/phpbb3/commit/a213324217bdef96235409155f9e764241abf761
2nd part:https://github.com/brunoais/phpbb3/commit/89d437a7498ab18234dee0b827347a3da500798e

Show
brunoais added a comment - Commit done. 1st part: https://github.com/brunoais/phpbb3/commit/a213324217bdef96235409155f9e764241abf761 2nd part: https://github.com/brunoais/phpbb3/commit/89d437a7498ab18234dee0b827347a3da500798e
Hide
Permalink
Joas Schilling added a comment -

> Add javascript code so that the permission disappears when it does not apply.

This seems a bit dangerous to me. When you set permissions for a role, the permission is hidden, as you do not edit permissions for a forum? But you can still use it on such a forum later and don't know, that this permission exists?

Show
Joas Schilling added a comment - > Add javascript code so that the permission disappears when it does not apply. This seems a bit dangerous to me. When you set permissions for a role, the permission is hidden, as you do not edit permissions for a forum? But you can still use it on such a forum later and don't know, that this permission exists?
Hide
Permalink
brunoais added a comment -

I need you to explain me that better. I didn't understand correctly the problem you are arising.
Try giving an example.

Show
brunoais added a comment - I need you to explain me that better. I didn't understand correctly the problem you are arising. Try giving an example.

People

  • Assignee:
    Unassigned
    Reporter:
    brunoais
Vote (0)
Watch (1)

Dates

  • Created:
    Updated: