phpBB3

Static calls in utf normalizer yield E_STRICT spam on php 5.4

Details

  • Type: Bug Bug
  • Status: Unverified Fix Unverified Fix
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 3.0.10
  • Fix Version/s: 3.0.11-RC1
  • Component/s: None
  • Labels:
    None

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. PHPBB3-7448 Module management calling non-static method p_master::module_auth()

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed can be reopened.
is related to

Task - A task that needs to be done. PHPBB3-10763 Audit code for non-static functions called statically

  • Blocker - Blocks development and/or testing work, production could not run.
  • Open - The issue is open and ready for the assignee to start work on it.

Task - A task that needs to be done. PHPBB3-10718 Add Travis CI

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Unverified Fix - A resolution has been taken, and it is awaiting verification by reporter. From here issues are either reopened, or are closed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Oleg added a comment -

I seem to recall some of that code being done that way for a reason. For 3.0 we maybe should silence E_STRICT on php 5.4+, for 3.1 the code needs to be fixed properly.

Show
Oleg added a comment - I seem to recall some of that code being done that way for a reason. For 3.0 we maybe should silence E_STRICT on php 5.4+, for 3.1 the code needs to be fixed properly.
Hide
Permalink
Andreas Fischer added a comment -

I guess msg_handler() is supposed to eat E_STRICT messages. Maybe it is not registered in the install environment.

Show
Andreas Fischer added a comment - I guess msg_handler() is supposed to eat E_STRICT messages. Maybe it is not registered in the install environment.
Hide
Permalink
Patrick Webster added a comment -

PHP 5.4 Alpha 3 added E_STRICT to E_ALL, since we don't catch it in the error handler it shows up.

Show
Patrick Webster added a comment - PHP 5.4 Alpha 3 added E_STRICT to E_ALL, since we don't catch it in the error handler it shows up.
Hide
Permalink
Andreas Fischer added a comment -

This was bound to happen. Let's decide what error flags we want to see and then let's get rid of E_ALL.

Show
Andreas Fischer added a comment - This was bound to happen. Let's decide what error flags we want to see and then let's get rid of E_ALL.
Hide
Permalink
Oleg added a comment -

I had that exact thought, but hasn't php over the years been inventing new flags and adding them to E_ALL? If so it's a lose-lose situation.

Show
Oleg added a comment - I had that exact thought, but hasn't php over the years been inventing new flags and adding them to E_ALL? If so it's a lose-lose situation.
Hide
Permalink
Andreas Fischer added a comment -

I don't see how my suggestion is a "lose situation" right now. My idea was that error_reporting(E_FOO | E_BAR | E_BARZ) is neither affected by new error levels E_ERR1 nor by adding E_FOO or E_ERR1 to E_ALL.

Show
Andreas Fischer added a comment - I don't see how my suggestion is a "lose situation" right now. My idea was that error_reporting(E_FOO | E_BAR | E_BARZ) is neither affected by new error levels E_ERR1 nor by adding E_FOO or E_ERR1 to E_ALL.
Hide
Permalink
Oleg added a comment -

If php adds E_VERY_FATAL which is included in E_ALL and has include() generate E_VERY_FATAL in some cases, and we don't have it included in our explicit list of error levels, we will start getting silent board destruction.

Show
Oleg added a comment - If php adds E_VERY_FATAL which is included in E_ALL and has include() generate E_VERY_FATAL in some cases, and we don't have it included in our explicit list of error levels, we will start getting silent board destruction.
Hide
Permalink
Oleg added a comment - - edited

I don't know whether the installer is affected but I just reproduced this and the original support topic talked about logging in.

With php 5.4.0-rc7 and current develop-olympus you cannot login from index.php:

Strict Standards: Non-static method utf_normalizer::nfkc() should not be called statically in /var/www/qi/boards/x11/includes/utf/utf_tools.php on line 1663

I will work on implementing the solution I proposed above.

Show
Oleg added a comment - - edited I don't know whether the installer is affected but I just reproduced this and the original support topic talked about logging in. With php 5.4.0-rc7 and current develop-olympus you cannot login from index.php: Strict Standards: Non-static method utf_normalizer::nfkc() should not be called statically in /var/www/qi/boards/x11/includes/utf/utf_tools.php on line 1663 I will work on implementing the solution I proposed above.
Hide
Permalink
Oleg added a comment -

I wrote the patch for 3.0, but 3.1 seems to work fine without it? I am confused.

Show
Oleg added a comment - I wrote the patch for 3.0, but 3.1 seems to work fine without it? I am confused.
Hide
Permalink
Oleg added a comment - - edited

(23:51:28) Noxwizard: nn-: If you go into the ACP's module management, you should hit the strict standards errors on 3.1.

Strict Standards: Non-static method p_master::module_auth() should not be called statically, assuming $this from incompatible context in /var/www/qi/boards/x3/includes/acp/acp_modules.php on line 644

(for about 10 pages)

Show
Oleg added a comment - - edited (23:51:28) Noxwizard: nn-: If you go into the ACP's module management, you should hit the strict standards errors on 3.1. Strict Standards: Non-static method p_master::module_auth() should not be called statically, assuming $this from incompatible context in /var/www/qi/boards/x3/includes/acp/acp_modules.php on line 644 (for about 10 pages)
Hide
Permalink
Oleg added a comment -

The reason 3.1 does not break on utf normalizer is Nils fixed it 2 years ago.

Show
Oleg added a comment - The reason 3.1 does not break on utf normalizer is Nils fixed it 2 years ago.
Hide
Permalink
Oleg added a comment -

https://github.com/phpbb/phpbb3/pull/626 silences spam on 3.0.

https://github.com/phpbb/phpbb3/pull/627 fixes the bug Noxwizard found for 3.1.

Show
Oleg added a comment - https://github.com/phpbb/phpbb3/pull/626 silences spam on 3.0. https://github.com/phpbb/phpbb3/pull/627 fixes the bug Noxwizard found for 3.1.
Hide
Permalink
Dragos Valentin Rădulescu added a comment -

I just moved hosts and im still getting this error on PHP 5.4.9. Tried the fix here, but my startup.php file is already modified. The errors appear when i sign in and visit a user profile. phpbb.com doesnt work

Show
Dragos Valentin Rădulescu added a comment - I just moved hosts and im still getting this error on PHP 5.4.9. Tried the fix here, but my startup.php file is already modified. The errors appear when i sign in and visit a user profile. phpbb.com doesnt work

People

  • Assignee:
    Oleg
    Reporter:
    Oleg
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: