Translation for errors

These messages are not provided by phpBB, but by the database client integrated in PHP. Some other messages are hardcoded in english, because the language system is not loaded at the point where the error happens. So there isn't much we can do.

The language of MySQL error messages can be changed by adjusting the relevant settings in the MySQL server configuration.

We cannot show dbal errors to users in their chosen language, because language choice is stored in the database. In the example error you gave, the error is from a failed database connection. Therefore the code cannot know what language the error should be displayed in.

The best that we can do is to store a "default language" in config.php, and use that in preference to english when, for example, displaying dbal errors.

Note that with http://tracker.phpbb.com/browse/PHPBB3-9359 fixed users will no longer see actual details of database issues; they would just see something like "there was a problem issuing a database query" or "there was a problem connecting to the database". Right now neither of these messages is going to be translatable; we can probably make the first one translatable but the second one won't be translatable for reasons I just described.

In any event board users (i.e. not administrators) cannot do anything about any of these errors. The only action users can take is report these errors to administrators, who should be able to figure out what they mean.

For displaying localized (and user"friendly") general DBMS errors I modified /includes/db/dbal.php to the approach of simply finding out which language the client prefers:

$aMsg= array
( 'en'=> 'The board is currently unplanned unavailable'
, 'de'=> 'Das Forum ist derzeit ungeplanterweise nicht erreichbar'
, 'es'=> 'El foro está disponible'
);

$sHay= ' ';
$sLang= 'en';  // English on default
					
// Search expected languages and agent language
foreach( array( 'HTTP_ACCEPT_LANGUAGE', 'HTTP_USER_AGENT' ) as $sHeader )
if( isset( $_SERVER[$sHeader] ) ) $sHay.= $_SERVER[$sHeader]. ' ';

// Find possible language identifiers
if( preg_match_all( '#[^a-z]([a-z]{2})[^a-z]#', $sHay, $aMatch ) )
foreach( $aMatch[1] as $sMatch )
if( isset( $aMsg[$sMatch] ) ) {  // Found supported language
	$sLang= $sMatch;
	break;
}
					
// Set message, which is EN in the worst case
$message= $aMsg[$sLang]. '<br/><br/>(Code: '. $this-> sql_error_returned['code']. ')';

(In the case of MySQL I'm showing this for the codes 1040 and 2001 to 2006)

While I do agree that HTTP_ACCEPT_LANGUAGE should be read and used for anonymous users, I do not see us translate error messages from database systems. Also, we can make it so you can use language keys in the "board disabled" field to get both things covered.