phpBB3

Version 3.010 not recognizing modified functions file in system's version check

Details

  • Type: Bug Bug
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: 3.0.9, 3.0.10
  • Fix Version/s: None
  • Component/s: ACP, Installation system
  • Labels:
    None
  • Environment:
    PHP 5.36, MySQL(i) 5.5.9, Safari and Firefox(most recent versions of both), Mac OSX

Description

I updated 3.09 to 3.010 a few days ago, and made all the necessary file merge/modifications manually with no problem. The general tab of the ACP recognizes this, and shows my Board Version as 3.010. However, under the systems tab of the ACP, it gives me an error saying that I need to update my version of phpbb to the latest one, thinking its still 3.09. When I go back through the update installation(after restoring the install directory), it repeatedly tells me that the includes/functions file needs the following segment to be modified, claiming there is a difference between the new includes/functions.php file and my own.
[code]
$s_search_hidden_fields = array();
if ($_SID)

{ $s_search_hidden_fields['sid'] = $_SID; }

if (!empty($_EXTRA_URL))
{
foreach ($_EXTRA_URL as $url_param)

{ $url_param = explode('=', $url_param, 2); $s_hidden_fields[$url_param[0]] = $url_param[1]; }

}
[/code]
I've copied and pasted the modified code it claims is wrong(and saved it, despite it being identical to what was there already), copied and edited it for perfect spacing since copy/paste adds extra rows(and saved it), and even gone in and retyped the entire modified segment from scratch(and saved it). And yet every time I run the files check, it tells me to merge the same modifications, even though they're already there. All other merge modifications have been fully successful.

I've attached a copy of my functions.php file.

  1. File
    functions_308.php
    19/Feb/12 4:28 AM
    136 kB
    Richard Foote
  2. File
    functions_309.php
    19/Feb/12 4:25 AM
    140 kB
    Richard Foote
  3. File
    functions.php
    08/Jan/12 1:34 PM
    151 kB
    vipaka

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Richard Foote added a comment -

The same has happened to me. When I get a moment, I will try to reproduce.

Duplicate of http://tracker.phpbb.com/browse/PHPBB3-8685
Same problem, different file: http://tracker.phpbb.com/browse/PHPBB3-9919

Show
Richard Foote added a comment - The same has happened to me. When I get a moment, I will try to reproduce. Duplicate of http://tracker.phpbb.com/browse/PHPBB3-8685 Same problem, different file: http://tracker.phpbb.com/browse/PHPBB3-9919
Hide
Permalink
Richard Foote added a comment -

I have updated several boards and a few of them have exhibited the problem. I can reproduce, but not consistently.
The commonality among the boards that gave the problem is that the includes/functions.php file has been modified by a MOD adding code
before 

	// The following assigns all _common_ variables that may be used at any point in a template.
	$template->assign_vars(array(
		'SITENAME'						=> $config['sitename'],

One thing I did notice that seems to be consistent is that after a successful update and checking the files again to verify a successful update, includes/functions.php would come up as needing to be modified by adding the following code again.

	if (!empty($_EXTRA_URL))
	{
		foreach ($_EXTRA_URL as $url_param)
		{
			$url_param = explode('=', $url_param, 2);
			$s_hidden_fields[$url_param[0]] = $url_param[1];
		}
	}
Show
Richard Foote added a comment - I have updated several boards and a few of them have exhibited the problem. I can reproduce, but not consistently. The commonality among the boards that gave the problem is that the includes/functions.php file has been modified by a MOD adding code before // The following assigns all _common_ variables that may be used at any point in a template. $template->assign_vars(array( 'SITENAME' => $config['sitename'], One thing I did notice that seems to be consistent is that after a successful update and checking the files again to verify a successful update, includes/functions.php would come up as needing to be modified by adding the following code again. if (!empty($_EXTRA_URL)) { foreach ($_EXTRA_URL as $url_param) { $url_param = explode('=', $url_param, 2); $s_hidden_fields[$url_param[0]] = $url_param[1]; } }
Hide
Permalink
Joas Schilling added a comment -

Can you post a file from before the update?

Show
Joas Schilling added a comment - Can you post a file from before the update?
Hide
Permalink
Richard Foote added a comment - - edited

I attached a 308 version and a 309 version which I used to update to 3.0.10.

As I mentioned, the problem is not consistent. These files may update correctly or they may not. The only thing that is consistent is that a problem file will always have code added by a MOD before 

 // The following assigns all _common_ variables that may be used at any point in a template.

Show
Richard Foote added a comment - - edited I attached a 308 version and a 309 version which I used to update to 3.0.10. As I mentioned, the problem is not consistent. These files may update correctly or they may not. The only thing that is consistent is that a problem file will always have code added by a MOD before // The following assigns all _common_ variables that may be used at any point in a template.

People

  • Assignee:
    Unassigned
    Reporter:
    vipaka
Vote (0)
Watch (0)

Dates

  • Created:
    Updated: